Issue 9021025: Check all cases with "__ movl(FieldAddress" and converted them to StoreIntoObject where appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9021025: Check all cases with "__ movl(FieldAddress" and converted them to StoreIntoObject where appropriate. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Check all cases with "__ movl(FieldAddress" and converted them to StoreIntoObject where appropriate. Committed: https://code.google.com/p/dart/source/detail?r=2714

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -14 lines)			Patch
M	vm/assembler_macros_ia32.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/code_generator_ia32.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	vm/intrinsifier_ia32.cc	View	4 chunks	+10 lines, -5 lines	0 comments	Download
M	vm/stub_code_ia32.cc	View	3 chunks	+14 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, same adjustment is needed for x64.

-Ivan