Check all cases with "__ movl(FieldAddress" and converted them to StoreIntoObject where appropriate.

vm/stub_code_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/ic_data.h"
@@ skipping 641 matching lines @@
     // EDI: Points to new space object.
     __ movl(Address(EDI, Scavenger::top_offset()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
 
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // ECX: array element type.
     // EDX: Array length as Smi.
 
     // Store the type argument field.
-    __ movl(FieldAddress(EAX, Array::type_arguments_offset()), ECX);
+    __ StoreIntoObject(EAX,
+                       FieldAddress(EAX, Array::type_arguments_offset()),
+                       ECX);
 
     // Set the length field.
-    __ movl(FieldAddress(EAX, Array::length_offset()), EDX);
+    __ StoreIntoObject(EAX,
+                       FieldAddress(EAX, Array::length_offset()),
+                       EDX);
 
     // Store class value for array.
     __ movl(ECX, FieldAddress(CTX, Context::isolate_offset()));
     __ movl(ECX, Address(ECX, Isolate::object_store_offset()));
     __ movl(ECX, Address(ECX, ObjectStore::array_class_offset()));
-    __ movl(FieldAddress(EAX, Array::class_offset()), ECX);
+    __ StoreIntoObject(EAX,
+                       FieldAddress(EAX, Array::class_offset()),
+                       ECX);
     __ movl(FieldAddress(EAX, Array::tags_offset()), Immediate(0));  // Tags.
 
     // Initialize all array elements to raw_null.
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // ECX: iterator which initially points to the start of the variable
     // data area to be initialized.
     __ leal(ECX, FieldAddress(EAX, Array::data_offset()));
     Label done;
     Label init_loop;
@@ skipping 280 matching lines @@
     // EAX: new object.
     // EBX: next object start.
     // EDX: number of context variables.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
 
     // Initialize the class field in the context object.
     // EAX: new object.
     // EDX: number of context variables.
     __ LoadObject(EBX, context_class);  // Load up class field of context.
-    __ movl(FieldAddress(EAX, Context::class_offset()), EBX);
+    __ StoreIntoObject(EAX,
+                       FieldAddress(EAX, Context::class_offset()),
+                       EBX);
     __ movl(FieldAddress(EAX, Context::tags_offset()), Immediate(0));  // Tags.
 
     // Setup up number of context variables field.
     // EAX: new object.
-    // EDX: number of context variables.
+    // EDX: number of context variables as integer value (not object).
     __ movl(FieldAddress(EAX, Context::num_variables_offset()), EDX);
 
     // Setup isolate field.
     // Load Isolate pointer from Context structure into EBX.
     // EAX: new object.
     // EDX: number of context variables.
     __ movl(EBX, FieldAddress(CTX, Context::isolate_offset()));
+    // EBX: Isolate, not an object.
     __ movl(FieldAddress(EAX, Context::isolate_offset()), EBX);
 
     const Immediate raw_null =
         Immediate(reinterpret_cast<intptr_t>(Object::null()));
     // Setup the parent field.
     // EAX: new object.
     // EDX: number of context variables.
     __ movl(FieldAddress(EAX, Context::parent_offset()), raw_null);
 
     // Initialize the context variables.
@@ skipping 638 matching lines @@
   __ popl(EDX);
   __ popl(ECX);
   __ LeaveFrame();
   // Now call the dynamic function.
   __ jmp(&StubCode::OneArgCheckInlineCacheLabel());
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32