Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 9016026: Moves over remaining .dart code references to 'factory' in interface declartions to 'default' (Closed)

Created:
9 years ago by zundel
Modified:
9 years ago
Reviewers:
mattsh, codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Moves over remaining .dart code references to 'factory' in interface declartions to 'default' BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -112 lines) Patch
M client/dom/generated/src/interface/AudioContext.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/FileReader.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Float32Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Float64Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Int16Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Int32Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Int8Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Uint16Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Uint32Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/Uint8Array.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/WebKitCSSMatrix.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/WebKitPoint.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/WebSocket.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/XMLHttpRequest.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/generated/src/interface/CSSMatrix.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/generated/src/interface/FileReader.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/generated/src/interface/Point.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/release/html.dart View 35 chunks +35 lines, -35 lines 0 comments Download
M client/html/src/AnimationEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/BeforeLoadEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/CSSStyleDeclaration.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/CloseEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/CompositionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/CustomEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/DeviceMotionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/DeviceOrientationEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/DocumentFragment.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/Element.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/ErrorEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/Event.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/HashChangeEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/KeyboardEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/MessageEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/MouseEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/MutationEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/OverflowEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/PageTransitionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/PopStateEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/ProgressEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/SVGElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/SVGSVGElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/StorageEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/Text.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/TextEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/TouchEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/TransitionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/UIEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/WheelEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/XMLHttpRequest.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/html/src/XMLHttpRequestProgressEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/samples/dartcombat/player.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M client/touch/Momentum.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 2 chunks +2 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.intfchange.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.newmethod.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 4 chunks +9 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/interfaces.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/actors/core/actors.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/belay/bcap/bcap.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/belay/bcap/src/BcapTunnel.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/http.dart View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
@Matt, could you look at the client and samples directories? For all but 2 case,s ...
9 years ago (2011-12-21 22:25:44 UTC) #1
codefu
On 2011/12/21 22:25:44, zundel wrote: > @John, I turned on a warning in dartc for ...
9 years ago (2011-12-21 22:31:51 UTC) #2
mattsh
9 years ago (2011-12-21 22:50:34 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698