Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 9016026: Moves over remaining .dart code references to 'factory' in interface declartions to 'default' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
diff --git a/compiler/java/com/google/dart/compiler/parser/DartParser.java b/compiler/java/com/google/dart/compiler/parser/DartParser.java
index eda9237afbf361346914e95d8dcaf53123ffec99..788f813926ca84edf7b4abe89b252054aff4ecbd 100644
--- a/compiler/java/com/google/dart/compiler/parser/DartParser.java
+++ b/compiler/java/com/google/dart/compiler/parser/DartParser.java
@@ -628,8 +628,7 @@ public class DartParser extends CompletionHooksParserBase {
private boolean optionalDeprecatedFactory() {
if (optionalPseudoKeyword(FACTORY_KEYWORD)) {
- // Uncommenting this makes tests fail until corelib is cleaned up
- // reportError(position(), ParserErrorCode.DEPRECATED_USE_OF_FACTORY_KEYWORD);
+ reportError(position(), ParserErrorCode.DEPRECATED_USE_OF_FACTORY_KEYWORD);
return true;
}
return false;
@@ -3742,7 +3741,7 @@ public class DartParser extends CompletionHooksParserBase {
private void reportError(DartNode node, ErrorCode errorCode, Object... arguments) {
reportError(new DartCompilationError(node, errorCode, arguments));
}
-
+
private boolean currentlyParsingToplevel() {
return !(isParsingInterface || isParsingAbstract || isParsingClass);
}

Powered by Google App Engine
This is Rietveld 408576698