Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 9003017: Use blocking file access in tools/test.dart for multitest creation. (Closed)

Created:
8 years, 11 months ago by Bill Hesse
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use blocking file access in tools/test.dart for multitest creation. Speeds up test.dart by a factor of 2, and test.dart --list by a factor of 6. Test.dart is now only 15% slower than test.py. BUG= TEST=tools/test.dart Committed: https://code.google.com/p/dart/source/detail?r=2889

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -55 lines) Patch
M tools/testing/dart/multitest.dart View 2 chunks +18 lines, -55 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
Speeds up multitest creation by a factor of 10. This was the main performance problem ...
8 years, 11 months ago (2011-12-30 16:12:23 UTC) #1
Søren Gjesse
8 years, 11 months ago (2012-01-02 10:03:50 UTC) #2
LGTM

Maybe we should open a bug on changing this back when the async operations have
been optimized.

Powered by Google App Engine
This is Rietveld 408576698