Use blocking file access in tools/test.dart for multitest creation.

tools/testing/dart/multitest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("multitest");
 
 // Multitests are Dart test scripts containing lines of the form
 // " [some dart code] /// [key]: [error type]"
 //
 // For each key in the file, a new test file is made containing all
@@ skipping 94 matching lines @@
   // Add the template, with no multitest lines, as a test with key 'none'.
   testsAsLines['none'] = testTemplate;
   outcomes['none'] = '';
   
   // Copy all the tests into the output map tests, as multiline strings.
   for (String key in testsAsLines.getKeys()) {
     tests[key] =
         Strings.join(testsAsLines[key], line_separator) + line_separator;
   }
 }
 

[Bill Hesse, 2011/12/30 16:12:23]

Oops.

-
 void DoMultitest(String filename,
                  String outputDir,
                  String testDir,
                  Function doTest(String filename,
                                  bool isNegative,
                                  [bool isNegativeIfChecked]),
                  Function multitestDone) {
   // Each new test is a single String value in the Map tests.
   Map<String, String> tests = new Map<String, String>();
   Map<String, String> outcomes = new Map<String, String>();
   ExtractTestsFromMultitest(filename, tests, outcomes);
 
   String directory = CreateMultitestDirectory(outputDir, testDir);
   String pathSeparator = new Platform().pathSeparator();
   int start = filename.lastIndexOf(pathSeparator) + 1;
   int end = filename.indexOf('.dart', start);
   String baseFilename = filename.substring(start, end);
-  Iterator currentKey = tests.getKeys().iterator();
-  WriteMultitestToFileAndQueueIt(tests,
-                                 outcomes,
-                                 currentKey,
-                                 '$directory$pathSeparator$baseFilename',
-                                 doTest,
-                                 multitestDone);
-}
+  for (String key in tests.getKeys()) {
+    final String filename = '$directory/${baseFilename}_$key.dart';
+    final File file = new File(filename);
 
-
-// Write multiple tests to files, using tail recursion in a callback
-// to serialize the file operations, rather than opening all files at once.
-WriteMultitestToFileAndQueueIt(Map<String, String> tests,
-                               Map<String, String> outcomes,
-                               Iterator currentKey,
-                               String basePath,
-                               Function doTest,
-                               Function done) {
-  if (!currentKey.hasNext()) {
-    done();
-    return;
+    file.createSync();
+    RandomAccessFile openedFile = file.openSync(writable: true);
+    var bytes = tests[key].charCodes();
+    openedFile.writeListSync(bytes, 0, bytes.length);
+    openedFile.closeSync();
+    var outcome = outcomes[key];
+    bool enableFatalTypeErrors = outcome.contains('static type error');
+    bool isNegative = (outcome.contains('compile-time error') ||
+                       outcome.contains('runtime error'));
+    bool isNegativeIfChecked = outcome.contains('dynamic type error');
+    doTest(filename,
+           isNegative,
+           isNegativeIfChecked,
+           enableFatalTypeErrors);
   }
-  final String key = currentKey.next();
-  final String filename = '${basePath}_$key.dart';
-  final File file = new File(filename);
-  file.errorHandler = (error) {
-    Expect.fail("Error creating temp file: $error");
-  };
-  file.createHandler = () {
-    file.open(writable: true);
-  };
-  file.openHandler = (RandomAccessFile openedFile) {
-    openedFile.noPendingWriteHandler =() {
-      openedFile.close();
-    };
-    openedFile.closeHandler = () {
-      var outcome = outcomes[key];
-      bool enableFatalTypeErrors = outcome.contains('static type error');
-      bool isNegative = (outcome.contains('compile-time error') ||
-                         outcome.contains('runtime error'));
-      bool isNegativeIfChecked = outcome.contains('dynamic type error');
-      doTest(filename,
-             isNegative,
-             isNegativeIfChecked,
-             enableFatalTypeErrors);
-      WriteMultitestToFileAndQueueIt(tests,
-                                     outcomes,
-                                     currentKey,
-                                     basePath,
-                                     doTest,
-                                     done);
-    };
-    var bytes = tests[key].charCodes();
-    openedFile.writeList(bytes, 0, bytes.length);
-  };
-  file.create();
+  multitestDone();
 }
 
 String CreateMultitestDirectory(String outputDir, String testDir) {
   final String generatedTestDirectory = 'generated_tests';
   Directory parentDir = new Directory(outputDir + generatedTestDirectory);
   if (!parentDir.existsSync()) {
     parentDir.createSync();
   }
   var split = testDir.split('/');
   var lastComponent = split.removeLast();
   Expect.isTrue(lastComponent == 'src');
   String path = '${parentDir.path}/${split.last()}';
   Directory dir = new Directory(path);
   if (!dir.existsSync()) {
     dir.createSync();
   }
   return path;
 }