Issue 9003001: Fix use of now-reserved word "class".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9003001: Fix use of now-reserved word "class". (Closed)

Created:
9 years ago by Bob Nystrom

Modified:
9 years ago

Reviewers:
mattsh

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix use of now-reserved word "class". Committed: https://code.google.com/p/dart/source/detail?r=2602

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	utils/dartdoc/dartdoc.dart	View		2 chunks	+4 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattsh

LGTM. http://codereview.chromium.org/9003001/diff/1/utils/dartdoc/dartdoc.dart File utils/dartdoc/dartdoc.dart (right): http://codereview.chromium.org/9003001/diff/1/utils/dartdoc/dartdoc.dart#newcode594 utils/dartdoc/dartdoc.dart:594: final cssClass = css == null ? '' ...

9 years ago (2011-12-19 23:35:06 UTC) #2

Bob Nystrom

9 years ago (2011-12-20 00:09:39 UTC) #3

Thanks!

http://codereview.chromium.org/9003001/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9003001/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:594: final cssClass = css == null ? '' : '
class="$css"';
On 2011/12/19 23:35:06, mattsh wrote:
> Seems like these should be reversed, i.e. css should be called cssClass, and
> cssClass should be called css.

I wanted the shorter name for the named argument.

Expand Messages | Collapse Messages