Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: utils/dartdoc/dartdoc.dart

Issue 9003001: Fix use of now-reserved word "class". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/dartdoc/dartdoc.dart
diff --git a/utils/dartdoc/dartdoc.dart b/utils/dartdoc/dartdoc.dart
index b7dd58ca75d7eed4097d19864c807d7f64b9db86..c9c97577c6dcf8799253abebfd3f709b4ccfc533 100644
--- a/utils/dartdoc/dartdoc.dart
+++ b/utils/dartdoc/dartdoc.dart
@@ -590,9 +590,9 @@ class Dartdoc {
* Creates a hyperlink. Handles turning the [href] into an appropriate
* relative path from the current file.
*/
- String a(String href, String contents, [String class]) {
- final css = class == null ? '' : ' class="$class"';
- return '<a href="${relativePath(href)}"$css>$contents</a>';
+ String a(String href, String contents, [String css]) {
+ final cssClass = css == null ? '' : ' class="$css"';
mattsh 2011/12/19 23:35:06 Seems like these should be reversed, i.e. css shou
Bob Nystrom 2011/12/20 00:09:39 I wanted the shorter name for the named argument.
+ return '<a href="${relativePath(href)}"$cssClass>$contents</a>';
}
/**
@@ -664,7 +664,7 @@ class Dartdoc {
typeReference(Type type) {
// TODO(rnystrom): Do we need to handle ParameterTypes here like
// annotation() does?
- return a(typeUrl(type), typeName(type), class: 'crossref');
+ return a(typeUrl(type), typeName(type), css: 'crossref');
}
/** Generates a human-friendly string representation for a type. */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698