Issue 8972005: More optimizations cleanup.

Issue 8972005: More optimizations cleanup. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More optimizations and cleanups. Committed: https://code.google.com/p/dart/source/detail?r=2548

Patch Set 8 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -18 lines)			Patch
M	runtime/lib/string.dart	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.h	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2 3 4 5 6 7	12 chunks	+140 lines, -16 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/src/OptimizationTest.dart	View	1 2 3 4 5 6	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generator_ia32.cc File runtime/vm/opt_code_generator_ia32.cc (right): http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generator_ia32.cc#newcode776 runtime/vm/opt_code_generator_ia32.cc:776: // Implement Token::kSUB. and kBIT_NOT.? http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generator_ia32.cc#newcode1277 runtime/vm/opt_code_generator_ia32.cc:1277: GenerateMintBinaryOp(node, ...

9 years ago (2011-12-16 22:24:26 UTC) #2

srdjan

9 years ago (2011-12-16 23:08:12 UTC) #3

Thanks!

http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generato...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:776: // Implement Token::kSUB.
On 2011/12/16 22:24:26, asiva wrote:
> and kBIT_NOT.?

Done.

http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:1277: GenerateMintBinaryOp(node, false);
On 2011/12/16 22:24:26, asiva wrote:
> GenerateMintBinaryOp also references mint_class, I wonder if it is worth
passing
> it down.

I would not as it complicates the interface unnecessarily, IMO. If I need to
eliminate "construction" of Mint handle, then I should cache it in
OptimizingCodeGenerator like smi_clas_.

http://codereview.chromium.org/8972005/diff/9004/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:2955: // TODO(srdjan): Implement unary
kSUB (negate) for doubles.
On 2011/12/16 22:24:26, asiva wrote:
> I presume a mint can also be similarly optimized.

Done.

Expand Messages | Collapse Messages