Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8972005: More optimizations cleanup. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/opt_code_generator_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 2547)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -433,6 +433,7 @@
// to the InstanceCall stub which will resolve the correct entrypoint for
// the operator and call it.
ICData ic_data(function_name, num_args_checked);
+ ASSERT(ic_data.NumberOfArgumentsChecked() == num_args_checked);
__ LoadObject(ECX, Array::ZoneHandle(ic_data.data()));
__ LoadObject(EDX, ArgumentsDescriptor(num_arguments,
optional_arguments_names));
@@ -1198,6 +1199,7 @@
}
node->operand()->Visit(this);
if (node->kind() == Token::kADD) {
+ // TODO(srdjan): Remove this as it is not part of Dart language any longer.
// Unary operator '+' does not exist, it's a NOP, skip it.
if (!IsResultNeeded(node)) {
__ popl(EAX);
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/opt_code_generator_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698