When generating the error message, don't overrun args.nodes .

When generating the error message, don't overrun args.nodes .

BUG=775
Committed: https://code.google.com/p/dart/source/detail?r=2528

[jimhug, 2011-12-16 17:29:39]

http://codereview.chromium.org/8966026/diff/3001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8966026/diff/3001/frog/member.dart#newcode962
frog/member.dart:962: (i >= args.nodes.length) ? null : args.nodes[i].span);
A better fix would be to use node.span instead of null so that some source
location information is provided.  You can make that change here or in _argError
- using node.span as a fallback when the directly passed span is null.

http://codereview.chromium.org/8966026/diff/3001/tests/language/src/Construct...
File tests/language/src/Constructor3NegativeTest.dart (right):

http://codereview.chromium.org/8966026/diff/3001/tests/language/src/Construct...
tests/language/src/Constructor3NegativeTest.dart:15: var k = new Klass();
FWIW - I'd add in another case here just to quickly cover both sides.

k = new Klass(1,2);

[dgrove, 2011-12-16 17:49:53]

http://codereview.chromium.org/8966026/diff/3001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8966026/diff/3001/frog/member.dart#newcode962
frog/member.dart:962: (i >= args.nodes.length) ? null : args.nodes[i].span);
On 2011/12/16 17:29:39, jimhug wrote:
> A better fix would be to use node.span instead of null so that some source
> location information is provided.  You can make that change here or in
_argError
> - using node.span as a fallback when the directly passed span is null.

Done.

http://codereview.chromium.org/8966026/diff/3001/tests/language/src/Construct...
File tests/language/src/Constructor3NegativeTest.dart (right):

http://codereview.chromium.org/8966026/diff/3001/tests/language/src/Construct...
tests/language/src/Constructor3NegativeTest.dart:15: var k = new Klass();
On 2011/12/16 17:29:39, jimhug wrote:
> FWIW - I'd add in another case here just to quickly cover both sides.
> 
> k = new Klass(1,2);

Done.

[jimhug, 2011-12-16 17:51:33]

lgtm