frog/minfrog - Issue 8966026: When generating the error message, don't overrun args.nodes .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/minfrog

Issue 8966026: When generating the error message, don't overrun args.nodes . (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/minfrog

===================================================================

--- frog/minfrog (revision 2524)

+++ frog/minfrog (working copy)

@@ -5595,7 +5595,7 @@

}

if (arg == null || !this.parameters.$index(i).get$isOptional()) {

var msg = MethodMember._argCountMsg(Math.min(i, args.get$length()), i + 1, true);

- return this._argError(context, node, target, args, msg, args.nodes.$index(i).get$span());

+ return this._argError(context, node, target, args, msg, (i >= args.nodes.get$length()) ? node.span : args.nodes.$index(i).get$span());

}

else {

argsCode.add$1(this.isConst && arg.get$isConst() ? arg.get$canonicalCode() : arg.get$code());

« no previous file with comments | « frog/member.dart ('k') | tests/language/src/Constructor3NegativeTest.dart » ('j') | no next file with comments »