Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 8956062: Issue 940 - Exception generating js for prefixed toplevel fields (Closed)

Created:
8 years, 11 months ago by codefu
Modified:
8 years, 11 months ago
Reviewers:
mmendez, scheglov, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 940 - Exception generating js for prefixed toplevel fields http://code.google.com/p/dart/issues/detail?id=940 Talked to Gilad about the abiguity of language spec between prefix identifiers and method invocation. P.id(...) looks like o.m(...) to the parser at the moment. Local fields are correctly represented in the AST as unqualified invocations. R=zundel,mmendez BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2910

Patch Set 1 #

Patch Set 2 : Adding test #

Patch Set 3 : After running global tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java View 1 chunk +8 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/Prefix21BadLib.dart View 1 1 chunk +13 lines, -0 lines 0 comments Download
A tests/language/src/Prefix21GoodLib.dart View 1 1 chunk +13 lines, -0 lines 0 comments Download
A tests/language/src/Prefix21Test.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
codefu
8 years, 11 months ago (2011-12-28 21:18:20 UTC) #1
scheglov
lgtm
8 years, 11 months ago (2011-12-28 21:37:52 UTC) #2
zundel
8 years, 11 months ago (2012-01-03 15:02:48 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698