Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java

Issue 8956062: Issue 940 - Exception generating js for prefixed toplevel fields (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: After running global tests Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
diff --git a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
index ae7d902c2c8588c445e352ba137e97d261b454e8..87ae13592b62927c983f588aeb5f2ec2b3fdcd55 100644
--- a/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
+++ b/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
@@ -2714,8 +2714,14 @@ public class GenerateJavascriptAST {
}
case FIELD: {
- mangledName = mangler.mangleNamedMethod(x.getFunctionNameString(), unitLibrary);
- qualifier = (JsExpression)generate(x.getTarget());
+ if(ElementKind.of(x.getTarget().getSymbol()) == ElementKind.LIBRARY) {
+ // Handled very much like a unqualified invocation
+ mangledName = null;
+ qualifier = (JsExpression) generate(x.getFunctionName());
+ } else {
+ mangledName = mangler.mangleNamedMethod(x.getFunctionNameString(), unitLibrary);
+ qualifier = (JsExpression) generate(x.getTarget());
+ }
break;
}
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698