Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Issue 8954016: Don't allow new of interface without constructors. (Closed)

Created:
9 years ago by mmendez
Modified:
9 years ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't allow new of interface without constructors. Addresses http://code.google.com/p/dart/issues/detail?id=868. The behavior of allowing default construction of interfaces that have factories has been there for sometime. We can remove that behavior once the issue has been settled. BUG=http://code.google.com/p/dart/issues/detail?id=868 Committed: https://code.google.com/p/dart/source/detail?r=2470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +2 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmendez
I found this issue while reviewing http://codereview.chromium.org/8948001.
9 years ago (2011-12-15 17:55:34 UTC) #1
zundel
9 years ago (2011-12-15 18:23:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698