Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Elements.java

Issue 8954016: Don't allow new of interface without constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/Elements.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Elements.java b/compiler/java/com/google/dart/compiler/resolver/Elements.java
index f9a37350ce250fca438fc8153af8486ae255b760..e47c7ee9994710bf180fe5863f7c30d5cf82ea3e 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Elements.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Elements.java
@@ -239,7 +239,8 @@ public class Elements {
* Returns true if the class needs an implicit default constructor.
*/
public static boolean needsImplicitDefaultConstructor(ClassElement classElement) {
- return !classElement.isObject() && classElement.getConstructors().isEmpty();
+ return !classElement.isObject() && classElement.getConstructors().isEmpty()
+ && (!classElement.isInterface() || classElement.getDefaultClass() != null);
}
/**
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698