Fix _ChildrenNodeList#forEach.

Fix _ChildrenNodeList#forEach.

TBR

Committed: https://code.google.com/p/dart/source/detail?r=2448

[Jacob, 2011-12-14 23:00:12]

Thanks for fixing.  I expect this broke as the Frog DOM doesn't really support
the full list interfaces at the moment.

http://codereview.chromium.org/8907051/diff/1/client/html/src/NodeWrappingImp...
File client/html/src/NodeWrappingImplementation.dart (right):

http://codereview.chromium.org/8907051/diff/1/client/html/src/NodeWrappingImp...
client/html/src/NodeWrappingImplementation.dart:27: for (int i = 0, len =
_childNodes.length; i < len; i++) {
what if the children change while iterating?
to be safe we have to copy the children to a temp array
or mitigate the issue somewhat by not caching len and adding a comment warning
of the edge case.

[nweiz, 2011-12-14 23:21:38]

http://codereview.chromium.org/8907051/diff/1/client/html/src/NodeWrappingImp...
File client/html/src/NodeWrappingImplementation.dart (right):

http://codereview.chromium.org/8907051/diff/1/client/html/src/NodeWrappingImp...
client/html/src/NodeWrappingImplementation.dart:27: for (int i = 0, len =
_childNodes.length; i < len; i++) {
On 2011/12/14 23:00:13, Jacob wrote:
> what if the children change while iterating?
> to be safe we have to copy the children to a temp array
> or mitigate the issue somewhat by not caching len and adding a comment warning
> of the edge case.
>  

That makes me realize, this could be implemented much more cleanly by just using
_toList.

[Jacob, 2011-12-14 23:33:46]

Got a new patch set?