Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 8893008: Helper ast node sequences must not wrongly grab ownership of the enclosing (Closed)

Created:
9 years ago by regis
Modified:
9 years ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Helper ast node sequences must not wrongly grab ownership of the enclosing scope (fix issue 736). Add test. Committed: https://code.google.com/p/dart/source/detail?r=2324

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M runtime/vm/ast.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/opt_code_generator_ia32.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 5 chunks +16 lines, -23 lines 0 comments Download
A tests/language/src/Closure2Test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
9 years ago (2011-12-09 20:00:12 UTC) #1
hausner
LGTM w/ tiny comment. http://codereview.chromium.org/8893008/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/8893008/diff/1/runtime/vm/parser.cc#newcode3609 runtime/vm/parser.cc:3609: // are not initialized. If ...
9 years ago (2011-12-09 21:19:21 UTC) #2
regis
9 years ago (2011-12-09 21:31:22 UTC) #3
Thanks

http://codereview.chromium.org/8893008/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8893008/diff/1/runtime/vm/parser.cc#newcode3609
runtime/vm/parser.cc:3609: // are not initialized. If several variables are
declared and initialized,
On 2011/12/09 21:19:21, hausner wrote:
> This comment is outdated, since variables are now always initialized (possibly
> implicitly). So NULL is never returned. Can you update it while you're working
> in the neighborhood?

Done.

Powered by Google App Engine
This is Rietveld 408576698