runtime/vm/opt_code_generator_ia32.cc - Issue 8893008: Helper ast node sequences must not wrongly grab ownership of the enclosing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/opt_code_generator_ia32.cc

Issue 8893008: Helper ast node sequences must not wrongly grab ownership of the enclosing (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/opt_code_generator_ia32.cc

===================================================================

--- runtime/vm/opt_code_generator_ia32.cc (revision 2323)

+++ runtime/vm/opt_code_generator_ia32.cc (working copy)

@@ -2567,8 +2567,9 @@

void OptimizingCodeGenerator::VisitSequenceNode(SequenceNode* node_sequence) {

- if (FLAG_enable_type_checks ||

- (node_sequence->scope()->num_context_variables() > 0)) {

+ const intptr_t num_context_variables = (node_sequence->scope() != NULL) ?

+ node_sequence->scope()->num_context_variables() : 0;

+ if (FLAG_enable_type_checks || (num_context_variables > 0)) {

CodeGenerator::VisitSequenceNode(node_sequence);

return;

}

« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »