Issue 8888020: Teach the assembler how to generate multi-byte nops. Teach the

Issue 8888020: Teach the assembler how to generate multi-byte nops. Teach the (Closed)

Created:
9 years ago by turnidge

Modified:
9 years ago

Reviewers:
srdjan, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Teach the assembler how to generate multi-byte nops. Teach the disassembler to understand them. Use multi-byte nops in Align(). Add tests.

Patch Set 5 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -7 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 2 3	2 chunks	+72 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 2	1 chunk	+81 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

DBC http://codereview.chromium.org/8888020/diff/3002/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/8888020/diff/3002/runtime/vm/assembler_ia32.cc#newcode1398 runtime/vm/assembler_ia32.cc:1398: while (bytes_needed > 8) { Maybe we should ...

9 years ago (2011-12-08 19:40:30 UTC) #2

turnidge

http://codereview.chromium.org/8888020/diff/3002/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/8888020/diff/3002/runtime/vm/assembler_ia32.cc#newcode1398 runtime/vm/assembler_ia32.cc:1398: while (bytes_needed > 8) { On 2011/12/08 19:40:30, asiva ...

9 years ago (2011-12-08 20:41:06 UTC) #3

srdjan

LGTM http://codereview.chromium.org/8888020/diff/4002/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/8888020/diff/4002/runtime/vm/assembler_ia32.cc#newcode1102 runtime/vm/assembler_ia32.cc:1102: ASSERT(0 < size && size <= MAX_NOP_SIZE); I ...

9 years ago (2011-12-08 22:18:12 UTC) #4

turnidge

9 years ago (2011-12-08 23:04:57 UTC) #5

http://codereview.chromium.org/8888020/diff/4002/runtime/vm/assembler_ia32.cc
File runtime/vm/assembler_ia32.cc (right):

http://codereview.chromium.org/8888020/diff/4002/runtime/vm/assembler_ia32.cc...
runtime/vm/assembler_ia32.cc:1102: ASSERT(0 < size && size <= MAX_NOP_SIZE);
On 2011/12/08 22:18:12, srdjan wrote:
> I would document this limitation in header file.

Done.

Expand Messages | Collapse Messages