Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 8888020: Teach the assembler how to generate multi-byte nops. Teach the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_ia32.cc
===================================================================
--- runtime/vm/disassembler_ia32.cc (revision 2148)
+++ runtime/vm/disassembler_ia32.cc (working copy)
@@ -1122,6 +1122,36 @@
Print(",");
PrintXmmRegister(rm);
data++;
+ } else if (f0byte == 0x1F) {
+ if (*(data+2) == 0x00) {
+ Print("nop");
+ data += 3;
+ } else if (*(data+2) == 0x40 && *(data+3) == 0x00) {
+ Print("nop");
+ data += 4;
+ } else if (*(data+2) == 0x44 &&
+ *(data+3) == 0x00 &&
+ *(data+4) == 0x00) {
+ Print("nop");
+ data += 5;
+ } else if (*(data+2) == 0x80 &&
+ *(data+3) == 0x00 &&
+ *(data+3) == 0x00 &&
+ *(data+3) == 0x00 &&
+ *(data+4) == 0x00) {
+ Print("nop");
+ data += 7;
+ } else if (*(data+2) == 0x84 &&
+ *(data+3) == 0x00 &&
+ *(data+3) == 0x00 &&
+ *(data+3) == 0x00 &&
+ *(data+3) == 0x00 &&
+ *(data+4) == 0x00) {
+ Print("nop");
+ data += 8;
+ } else {
+ UNIMPLEMENTED();
+ }
} else {
data += 2;
if (f0byte == 0xAB || f0byte == 0xA5 || f0byte == 0xAD) {
@@ -1266,9 +1296,18 @@
PrintXmmRegister(regop);
Print(",");
data += PrintRightXmmOperand(data);
+ } else if (*data == 0x1F &&
+ *(data+1) == 0x44 &&
+ *(data+2) == 0x00 &&
+ *(data+3) == 0x00) {
+ data += 4;
+ Print("nop");
} else {
UNIMPLEMENTED();
}
+ } else if (*data == 0x90) {
+ data++;
+ Print("nop");
} else {
UNIMPLEMENTED();
}
« no previous file with comments | « runtime/vm/assembler_ia32_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698