Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 8879058: Change temp dir generation on Windows to use UUIDs instead of random numbers (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change temp dir generation on Windows to use UUIDs instead of random numbers This avoids having to generate random numbers for all platforms as only Windows was using them. Also when the andom number generator is deterministic the Windows implementation using random numbers could end up running out of temporary files. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2417

Patch Set 1 #

Patch Set 2 : Lower temp dir nesting on Windows #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/directory.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/directory_impl.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M runtime/bin/directory_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/directory_win.cc View 2 chunks +29 lines, -17 lines 0 comments Download
M tests/standalone/src/DirectoryTest.dart View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years ago (2011-12-13 15:55:59 UTC) #1
Bill Hesse
9 years ago (2011-12-13 16:24:27 UTC) #2
LGTM.

Not really happy about the length of the directory name.

Powered by Google App Engine
This is Rietveld 408576698