Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/bin/directory.cc

Issue 8879058: Change temp dir generation on Windows to use UUIDs instead of random numbers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory.h ('k') | runtime/bin/directory_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory.cc
diff --git a/runtime/bin/directory.cc b/runtime/bin/directory.cc
index ece92ae9caa6586248fb30b54b14f28e83ab44f2..df2e7fda82df1d1a2728b751de957f541cca4ff3 100644
--- a/runtime/bin/directory.cc
+++ b/runtime/bin/directory.cc
@@ -79,11 +79,10 @@ void FUNCTION_NAME(Directory_Create)(Dart_NativeArguments args) {
void FUNCTION_NAME(Directory_CreateTemp)(Dart_NativeArguments args) {
Dart_EnterScope();
Dart_Handle path = Dart_GetNativeArgument(args, 0);
- Dart_Handle number = Dart_GetNativeArgument(args, 1);
- Dart_Handle status_handle = Dart_GetNativeArgument(args, 2);
+ Dart_Handle status_handle = Dart_GetNativeArgument(args, 1);
static const int kMaxChildOsErrorMessageLength = 256;
char os_error_message[kMaxChildOsErrorMessageLength];
- if (!Dart_IsString(path) || !Dart_IsInteger(number)) {
+ if (!Dart_IsString(path)) {
DartUtils::SetIntegerInstanceField(status_handle, "_errorCode", 0);
DartUtils::SetStringInstanceField(
status_handle, "_errorMessage", "Invalid arguments");
@@ -94,7 +93,6 @@ void FUNCTION_NAME(Directory_CreateTemp)(Dart_NativeArguments args) {
char* result = NULL;
int error_code = Directory::CreateTemp(DartUtils::GetStringValue(path),
- DartUtils::GetIntegerValue(number),
&result,
os_error_message,
kMaxChildOsErrorMessageLength);
« no previous file with comments | « runtime/bin/directory.h ('k') | runtime/bin/directory_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698