Issue 8879006: frog: detect when getter/setter has incorrect number of arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8879006: frog: detect when getter/setter has incorrect number of arguments. (Closed)

Created:
9 years ago by Siggi Cherem (dart-lang)

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

frog: detect when getter/setter has incorrect number of arguments. Committed: https://code.google.com/p/dart/source/detail?r=2217

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -4 lines)			Patch
M	frog/member.dart	View	1 chunk	+14 lines, -2 lines	2 comments	Download
M	frog/minfrog	View	1 chunk	+12 lines, -2 lines	0 comments	Download
A	tests/language/src/GetterDeclarationNegativeTest.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	tests/language/src/SetterDeclaration2NegativeTest.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	tests/language/src/SetterDeclarationNegativeTest.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm http://codereview.chromium.org/8879006/diff/1/frog/member.dart File frog/member.dart (right): http://codereview.chromium.org/8879006/diff/1/frog/member.dart#newcode547 frog/member.dart:547: if (setter.parameters.length != 1) { is it worth ...

9 years ago (2011-12-08 03:22:30 UTC) #3

Siggi Cherem (dart-lang)

9 years ago (2011-12-08 20:43:53 UTC) #4

http://codereview.chromium.org/8879006/diff/1/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8879006/diff/1/frog/member.dart#newcode547
frog/member.dart:547: if (setter.parameters.length != 1) {
On 2011/12/08 03:22:30, John Messerly wrote:
> is it worth warning if getter.returnType.isVoid, or !setter.returnType.isVoid?

addressing in follow up CL.

Expand Messages | Collapse Messages