Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Issue 8788001: Trying to unbreak dart editor build - new use of rollback messes up code completion (Closed)

Created:
9 years ago by zundel
Modified:
9 years ago
Reviewers:
messick, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Trying to unbreak dart editor build - new use of rollback messes up code completion Committed: https://code.google.com/p/dart/source/detail?r=2038

Patch Set 1 #

Patch Set 2 : Updated to fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java View 1 chunk +2 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java View 1 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
9 years ago (2011-12-02 22:12:38 UTC) #1
messick
lgtm Thanks!
9 years ago (2011-12-02 22:14:43 UTC) #2
danrubel
9 years ago (2011-12-02 22:29:09 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698