Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java

Issue 8788001: Trying to unbreak dart editor build - new use of rollback messes up code completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated to fix unit test Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/DartParser.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java
diff --git a/compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java b/compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java
index 49f71fbb8949c11bcc43ce33b7fe49855f50ecd0..35901cdefa3d9049ceeed4b4cffa11d374e24da4 100644
--- a/compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java
+++ b/compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java
@@ -434,7 +434,8 @@ public abstract class CompletionHooksParserBase extends AbstractParser {
/**
* This should only be called when the parser is looking ahead to decide how
- * to parse something, and this will always be rolled back.
+ * to parse something, and this will always be rolled back without any other {@link #begin()}
+ * statements being called.
*/
protected void startLookahead() {
begin();
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/DartParser.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698