Issue 8773004: tools/test.dart: Add synchronization, so the process queue knows when all multitests are done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8773004: tools/test.dart: Add synchronization, so the process queue knows when all multitests are done. (Closed)

Created:
9 years ago by Bill Hesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

tools/test.dart: Add synchronization, so the process queue knows when all multitests are done. BUG= TEST=tools/test.dart Committed: https://code.google.com/p/dart/source/detail?r=1974

Patch Set 2 : Address comments, fix type error. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -9 lines)			Patch
	M	tools/testing/dart/multitest.dart	View	1	4 chunks	+12 lines, -6 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1	4 chunks	+21 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/8773004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/8773004/diff/1/tools/testing/dart/test_suite.dart#newcode247 tools/testing/dart/test_suite.dart:247: if (activeMultitests == 0 && listingDone) { You ...

9 years ago (2011-12-01 11:50:47 UTC) #2

Fixed a type error.

Expand Messages | Collapse Messages

Issue 8773004: tools/test.dart: Add synchronization, so the process queue knows when all multitests are done. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments, fix type error. #

Messages