tools/test.dart: Add synchronization, so the process queue knows when all multitests are done.

tools/testing/dart/multitest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("multitest");
 
 // Multitests are Dart test scripts containing lines of the form
 // " [some dart code] /// [key]: [error type]"
 //
 // For each key in the file, a new test file is made containing all
@@ skipping 100 matching lines @@
   for (String key in testsAsLines.getKeys()) {
     tests[key] =
         Strings.join(testsAsLines[key], line_separator) + line_separator;
   }
 }
 
 
 void DoMultitest(String filename,
                  String buildDir,
                  String testDir,
-                 Function doTest(List<String> args,
+                 Function doTest(String filename,
                                  bool isNegative,
-                                 bool isNegativeIfChecked)) {
+                                 [bool isNegativeIfChecked]),
+                 Function multitestDone) {
   // Each new test is a single String value in the Map tests.
   Map<String, String> tests = new Map<String, String>();
   Map<String, String> outcomes = new Map<String, String>();
   ExtractTestsFromMultitest(filename, tests, outcomes);
 
   String directory = CreateMultitestDirectory(buildDir, testDir);
   String pathSeparator = new Platform().pathSeparator();
   int start = filename.lastIndexOf(pathSeparator) + 1;
   int end = filename.indexOf('.dart', start);
   String baseFilename = filename.substring(start, end);
   Iterator currentKey = tests.getKeys().iterator();
   WriteMultitestToFileAndQueueIt(tests, outcomes, currentKey,
-      '$directory$pathSeparator$baseFilename', doTest);
+                                 '$directory$pathSeparator$baseFilename',
+                                 doTest, multitestDone);
 }
 
 
 // Write multiple tests to files, using tail recursion in a callback
 // to serialize the file operations, rather than opening all files at once.
 WriteMultitestToFileAndQueueIt(Map<String, String> tests,
                                Map<String, String> outcomes,
                                Iterator currentKey,
                                String basePath,
-                               Function doTest) {
-  if (!currentKey.hasNext()) return;
+                               Function doTest,
+                               Function done) {
+  if (!currentKey.hasNext()) {
+    done();
+    return;
+  }
   final String key = currentKey.next();
   final String filename = '${basePath}_$key.dart';
   final File file = new File(filename);
   file.errorHandler = (error) {
     Expect.fail("Error creating temp file: $error");
   };
   file.createHandler = () {
     file.open(writable: true);
   };
   file.openHandler =  () {
     var bytes = tests[key].charCodes();
     file.writeList(bytes, 0, bytes.length);
   };
   file.noPendingWriteHandler =() {
     file.close();
   };
   file.closeHandler = () {
     var outcome = outcomes[key];
     bool isNegative = outcome.contains('compile-time error') ||
     outcome.contains('runtime error');
     bool isNegativeIfChecked = outcome.contains('type error');
     doTest(filename, isNegative, isNegativeIfChecked);
     // TODO(whesse): Register files and directories to be deleted.
     // They should be registered in a persistent list, so they can
     // be deleted later even if the test script is interrupted.
     WriteMultitestToFileAndQueueIt(tests, outcomes, currentKey,
-                                   basePath, doTest);
+                                   basePath, doTest, done);
   };
   file.create();
 }
 
 String CreateMultitestDirectory(String buildDir, String testDir) {
   final String generatedTestDirectory = 'generated_tests/';
   Directory parent_dir = new Directory(buildDir + generatedTestDirectory);
   if (!parent_dir.existsSync()) {
     parent_dir.createSync();
   }
   final String prefix = 'tests/';
   final String suffix = '/src';
   Expect.isTrue(testDir.startsWith(prefix));
   Expect.isTrue(testDir.endsWith(suffix));
   String path = parent_dir.path +
       testDir.substring(prefix.length, testDir.length - suffix.length);
   Directory dir = new Directory(path);
   if (!dir.existsSync()) {
     dir.createSync();
   }
   return path;
 }