Issue 8761007: Stop using void* types in the dart embedding api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8761007: Stop using void* types in the dart embedding api. (Closed)

Created:
9 years ago by turnidge

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Stop using void* types in the dart embedding api. Committed: https://code.google.com/p/dart/source/detail?r=1988

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -50 lines)			Patch
M	runtime/include/dart_api.h	View	1 2 3 4	5 chunks	+10 lines, -17 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 2 3 4	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/dart.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4	5 chunks	+14 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	1 chunk	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/message_queue_test.cc	View	1 2 3 4	7 chunks	+17 lines, -10 lines	0 comments	Download
M	runtime/vm/port.cc	View	1 2 3 4	4 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/port_test.cc	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

turnidge

You might be upset about me dropping the Dart_Snapshot type, not sure. The deal is ...

9 years ago (2011-12-01 00:09:22 UTC) #1

LGTM -ip