Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: runtime/lib/isolate.cc

Issue 8761007: Stop using void* types in the dart embedding api. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/isolate.cc
===================================================================
--- runtime/lib/isolate.cc (revision 1987)
+++ runtime/lib/isolate.cc (working copy)
@@ -7,6 +7,7 @@
#include "vm/assert.h"
#include "vm/class_finalizer.h"
#include "vm/dart.h"
+#include "vm/dart_api_impl.h"
#include "vm/dart_entry.h"
#include "vm/exceptions.h"
#include "vm/longjump.h"
@@ -43,7 +44,7 @@
}
-static void* SerializeObject(const Instance& obj) {
+static uint8_t* SerializeObject(const Instance& obj) {
uint8_t* result = NULL;
SnapshotWriter writer(false, &result, &allocator);
writer.WriteObject(obj.raw());
@@ -338,10 +339,10 @@
intptr_t send_id = Smi::CheckedHandle(arguments->At(0)).Value();
intptr_t reply_id = Smi::CheckedHandle(arguments->At(1)).Value();
// TODO(iposva): Allow for arbitrary messages to be sent.
- void* data = SerializeObject(Instance::CheckedHandle(arguments->At(2)));
+ uint8_t* data = SerializeObject(Instance::CheckedHandle(arguments->At(2)));
// TODO(turnidge): Throw an exception when the return value is false?
- PortMap::PostMessage(send_id, reply_id, data);
+ PortMap::PostMessage(send_id, reply_id, Api::CastMessage(data));
}
} // namespace dart
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698