Issue 8758005: Disassembler for x64.

Issue 8758005: Disassembler for x64. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disassembler for x64. Committed: https://code.google.com/p/dart/source/detail?r=1953

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -72 lines)			Patch
M	runtime/vm/disassembler.h	View	1	4 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/disassembler.cc	View	1	1 chunk	+5 lines, -51 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	1	1 chunk	+20 lines, -4 lines	0 comments	Download
M	runtime/vm/disassembler_test.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View	1	3 chunks	+84 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h File runtime/vm/disassembler.h (right): http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h#newcode32 runtime/vm/disassembler.h:32: virtual void Print(const char* format, ...

9 years ago (2011-11-30 22:42:12 UTC) #2

regis

9 years ago (2011-11-30 23:11:51 UTC) #3

Thanks

http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h
File runtime/vm/disassembler.h (right):

http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h#newco...
runtime/vm/disassembler.h:32: virtual void Print(const char* format, ...) = 0;
On 2011/11/30 22:42:12, Ivan Posva wrote:
> Can you add a TODO to remove this once we have the real x64 disassembler?

Done.

http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h#newco...
runtime/vm/disassembler.h:71: static void DisassembleMemoryRegionRange(const
MemoryRegion& instructions,
On 2011/11/30 22:42:12, Ivan Posva wrote:
> Not sure if this is really needed. Siva, do you see any need for keeping this
> alive?

Removed for now since unused.

http://codereview.chromium.org/8758005/diff/1/runtime/vm/disassembler.h#newco...
runtime/vm/disassembler.h:97: static const char* RegisterName(Register reg);
Also removed since unused.

Expand Messages | Collapse Messages