Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: runtime/vm/disassembler.h

Issue 8758005: Disassembler for x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/disassembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler.h
===================================================================
--- runtime/vm/disassembler.h (revision 1951)
+++ runtime/vm/disassembler.h (working copy)
@@ -27,6 +27,10 @@
char* human_buffer,
intptr_t human_size,
uword pc) = 0;
+
+ // TODO(regis): Remove Print function once we have a real x64 disassembler.
+ // Print a formatted message.
+ virtual void Print(const char* format, ...) = 0;
};
@@ -43,6 +47,8 @@
intptr_t human_size,
uword pc);
+ virtual void Print(const char* format, ...);
+
private:
DISALLOW_ALLOCATION()
DISALLOW_COPY_AND_ASSIGN(DisassembleToStdout);
@@ -63,10 +69,6 @@
}
// Disassemble instructions in a memory region.
- static void DisassembleMemoryRegionRange(const MemoryRegion& instructions,
- uword from,
- uword to,
- DisassemblyFormatter* formatter);
static void DisassembleMemoryRegion(const MemoryRegion& instructions,
DisassemblyFormatter* formatter) {
uword start = instructions.start();
@@ -87,10 +89,6 @@
char* human_buffer, intptr_t human_size,
uword pc);
- // Returns the name for the given register. For instance the Register EAX
- // returns the string "eax".
- static const char* RegisterName(Register reg);
-
private:
static const int kHexadecimalBufferSize = 32;
static const int kUserReadableBufferSize = 256;
« no previous file with comments | « no previous file | runtime/vm/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698