Chromium Code Reviews
DescriptionFix a bunch of issues with 'hidden' DOM types.
Hidden DOM types are types whose prototype is not accessible until you have an instance--they cannot be used at init time.
Issues fixed for these types include:
* "is", type assertions, and getters/setters are now inserted on the prototype lazily
* now patches correct prototype when binding these
* handles incompatible hidden native overloads (rare in practice, but we have a test case for it)
Also some other type check fixes:
* Type checks handle false correctly
* Dart TypeError is now used (before--would pick up the JS one)
* TypeError has an actually usable error message
These last fixes cause some code bloat (lots of type check fallbacks on Object.prototype), but for right now I think it's more important to give good errors.
Committed: https://code.google.com/p/dart/source/detail?r=1916
Patch Set 1 #Patch Set 2 : removed dead code #
Total comments: 2
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||