Fix a bunch of issues with 'hidden' DOM types.

frog/lib/corelib.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("dart:core");
 #import("dart:coreimpl");
 
 // TODO(jimhug): Better way to map in standard corelib
 #source("../../corelib/src/bool.dart");
 #source("../../corelib/src/collection.dart");
@@ skipping 50 matching lines @@
   write('\n');
 }''' {
   // ensure toString is generated
   obj.toString();
 }
 
 // Exceptions thrown by the generated JS code.
 
 class AssertError {
   final String failedAssertion;
+
+  // TODO(jmesserly): I don't think these should be here. They are properties of
+  // the stack trace
   final String url;
   final int line;
   final int column;
 
-  AssertError(this.failedAssertion, this.url, this.line, this.column);
+  AssertError._internal(this.failedAssertion, this.url, this.line, this.column);
 
   String toString() {
     return "Failed assertion: '$failedAssertion' is not true " +
         "in $url at line $line, column $column.";
   }
 }
 
-class TypeError extends AssertError {
+// TODO(jmesserly): fix the strange interaction with JS TypeError, such as
+// toString(). Ideally this would generate to a different JS name but I'm not
+// sure how to force that.
+class TypeError extends AssertError native 'TypeError' {
   final String srcType;
   final String dstType;
 
-  TypeError(this.srcType, this.dstType) : super(null, null, null, null);
-
-  String toString() {
-    return "Failed type check: type $srcType is not assignable to type " +
-        "$dstType";
-  }
+  TypeError._internal(Object src, String dstType) native @'''
+this.srcType = (src == null ? "Null" : src.$typeNameOf());
+this.destType = destType;

[sra1, 2011/11/30 23:12:49]

BUG: dstType vs destType.

You should add a test that checks the TypeError has the expected content in it's
message.

[Jennifer Messerly, 2011/12/01 00:38:07]

Good catch! Hopefully we can make this entire method non-native, once
$typeNameOf is fixed and the strange issue with colliding TypeError types is
fixed.

BTW -- feel free to just check in fixes for one liners like this. :)

+this.toString = function() {
+  return ("Failed type check: type " + this.srcType +
+      " is not assignable to type" + this.dstType);
+}''';
 }
 
 class FallThroughError {
-
   const FallThroughError();
 
-  String toString() {
-    return "Switch case fall-through.";
-  }
+  String toString() => "Switch case fall-through.";
 }
 
 // Dart core library.
 
 class Object native "Object" {
 
   const Object() native;
 
   bool operator ==(Object other) native;
   String toString() native;
 
   // TODO(jmesserly): optimize this. No need to call it.
   get dynamic() => this;
 
   // TODO(jmesserly): add named args. For now stay compatible with the VM.
   noSuchMethod(String name, List args) {
     throw new NoSuchMethodException(this, name, args);
   }
 }