Issue 8739002: Frog: Fix parsing of hex literals with >31 bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8739002: Frog: Fix parsing of hex literals with >31 bits (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
jimhug

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Frog: Fix parsing of hex literals with >31 bits BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1912

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : add issue numbers to comment #

Patch Set 4 : put issue# in comment #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
M	frog/frogsh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/parser.dart	View	1 2 3	1 chunk	+6 lines, -2 lines	0 comments	Download
A	tests/language/src/NumberConstantFolding1Test.dart	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

On 2011/11/30 01:35:32, sra1 wrote: lgtm Although it's an interesting question of what we want ...

9 years ago (2011-11-30 01:43:38 UTC) #2

jimhug

9 years ago (2011-11-30 01:52:11 UTC) #3

lgtm

But please add a TODO and an issue that the correct behavior of int-like types
in JS beyond 31 bits and in general of this kind of hex parsing beyond the
53-bitish range still needs to be figured out.

Expand Messages | Collapse Messages