Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tests/language/src/NumberConstantFolding1Test.dart

Issue 8739002: Frog: Fix parsing of hex literals with >31 bits (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: put issue# in comment Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/src/NumberConstantFolding1Test.dart
diff --git a/tests/language/src/NumberConstantFolding1Test.dart b/tests/language/src/NumberConstantFolding1Test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..1d48f7be31bd511c5c088bd7cc95fed93c01f6b0
--- /dev/null
+++ b/tests/language/src/NumberConstantFolding1Test.dart
@@ -0,0 +1,30 @@
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// On frogsh constant folded hex literals of large magnitude were truncated on
+// constant folding - Issue 636 is 'fixed', remaining concerns at Issue 638.
+
+
+highDigitTruncationTest() {
+ Expect.equals(0x12345678A, 0x123456789 + 1);
+
+ // in 32 bits this is 0xF0000000 which is negative.
+ Expect.isTrue(0x1f0000000 > 0);
+
+ Expect.equals(0xf0, 0xf * 16);
+ Expect.equals(0xff0, 0xff * 16);
+ Expect.equals(0xfff0, 0xfff * 16);
+ Expect.equals(0xffff0, 0xffff * 16);
+ Expect.equals(0xfffff0, 0xfffff * 16);
+ Expect.equals(0xffffff0, 0xffffff * 16);
+ Expect.equals(0xfffffff0, 0xfffffff * 16);
+ Expect.equals(0xffffffff0, 0xffffffff * 16);
+ Expect.equals(0xfffffffff0, 0xfffffffff * 16);
+ Expect.equals(0xffffffffff0, 0xffffffffff * 16);
+}
+
+
+main() {
+ highDigitTruncationTest();
+}
« no previous file with comments | « frog/parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698