Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 8659041: Fix recursion bug when adding members to native JS objects. (Closed)

Created:
9 years ago by mmendez
Modified:
9 years ago
Reviewers:
fabiomfv
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix recursion bug when adding members to native JS objects. Committed: https://code.google.com/p/dart/source/detail?r=1896

Patch Set 1 #

Patch Set 2 : Address offline comment about parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java View 1 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/backend/js/analysis/DependencyComputerTest.java View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmendez
9 years ago (2011-11-29 16:12:07 UTC) #1
fabiomfv
9 years ago (2011-11-29 16:14:16 UTC) #2
On 2011/11/29 16:12:07, mmendez wrote:

LGTM++

Powered by Google App Engine
This is Rietveld 408576698