compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java - Issue 8659041: Fix recursion bug when adding members to native JS objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java

Issue 8659041: Fix recursion bug when adding members to native JS objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address offline comment about parens Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java

diff --git a/compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java b/compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java

index 493c55c9d3edf104e047e3bafd62275bb3c2a397..52884d714f7d833b11eb338642b98b3b61704234 100644

--- a/compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java

+++ b/compiler/java/com/google/dart/compiler/backend/js/analysis/DependencyComputer.java

@@ -96,7 +96,7 @@ class DependencyComputer {

Symbol symbol = scope.getSymbol(name);

if (symbol == null) {

Scope parentScope = scope.getParentScope();

- if (parentScope == null) {

+ if (parentScope == null && (scope != scope.getAstRoot())) {

return findSymbol(scope.getAstRoot(), name);

} else {

return findSymbol(parentScope, name);

« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/backend/js/analysis/DependencyComputerTest.java » ('j') | no next file with comments »