Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 8631010: Move bundled libraries out of plugins (Closed)

Created:
9 years, 1 month ago by danrubel
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move bundled libraries out of plugins Committed: https://code.google.com/p/dart/source/detail?r=1857

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -542 lines) Patch
M editor/docs/README.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature/feature.xml View 1 2 chunks +0 lines, -31 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build-common.xml View 1 1 chunk +54 lines, -0 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build-settings/default-user.properties View 1 1 chunk +3 lines, -0 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build-settings/user.properties View 1 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml View 1 7 chunks +90 lines, -73 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.feature/feature.xml View 1 1 chunk +0 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/.options View 1 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/plugin.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core/schema/libraries.exsd View 1 1 chunk +0 lines, -119 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCoreDebug.java View 1 1 chunk +1 line, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/BundledSystemLibraryManager.java View 1 1 chunk +0 lines, -159 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java View 1 3 chunks +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProvider.java View 1 1 chunk +159 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java View 1 2 chunks +1 line, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/BundledSystemLibraryManagerTest.java View 1 1 chunk +0 lines, -118 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java View 1 5 chunks +34 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java View 1 1 chunk +110 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/TestAll.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/META-INF/MANIFEST.MF View 1 1 chunk +0 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java View 1 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
This is the first step in multi step process for bundling an SDK with Dart ...
9 years, 1 month ago (2011-11-22 12:40:08 UTC) #1
devoncarew
lgtm Fantastic stuff! This will resolve several user issues and put us closer towards consuming ...
9 years, 1 month ago (2011-11-22 18:50:19 UTC) #2
Mark R Russell
LGTM on the build stuff
9 years, 1 month ago (2011-11-23 13:41:15 UTC) #3
danrubel
9 years ago (2011-11-27 16:07:13 UTC) #4
On 2011/11/22 18:50:19, devoncarew wrote:
> The server launch CL I just landed has changes in many of the same files. You
> should do an update and merge to make sure that things still look good.

Thanks for the heads up. Changes merged.

> I'm concerned about the new ant step for editor developers - we'll have to run
> this (and remember to run it ) fairly frequently. Per our discussion, I like a
> linking based approach. We should also print out where we copy / link the
> libraries directory, so we give the developer a chance to modify it as
> necessary.

The script prints a message indicating the location of the "libraries"
directory.
I also updated the error message indicating what Ant properties need to be
defined.

> The coping step that modifies the dart file names is problematic because then
> dart developers working on the core libs will not be able to use the editor to
> do their work.

Good point. I've split that change out into a separate CL that renames the
source file rather than renaming the files when building the "libraries"
directory.

Powered by Google App Engine
This is Rietveld 408576698