Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java

Issue 8631010: Move bundled libraries out of plugins (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.deploy/META-INF/MANIFEST.MF ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java (revision 1856)
+++ editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/ExternalCompilationUnitEditorInput.java (working copy)
@@ -13,7 +13,6 @@
*/
package com.google.dart.tools.ui.internal.text.editor;
-import com.google.dart.tools.core.internal.model.BundledSystemLibraryManager;
import com.google.dart.tools.core.internal.model.ExternalCompilationUnitImpl;
import org.eclipse.core.filesystem.IFileStore;
@@ -70,18 +69,12 @@
* @return whether this editor input if modifiable
*/
public boolean isModifiable() {
- return !isFromBundle();
+ // TODO (danrubel) Investigate implementing or removing this method in future CL
+ return true;
}
@Override
public void saveState(IMemento memento) {
ExternalCompilationUnitEditorInputFactory.saveState(memento, this);
}
-
- private boolean isFromBundle() {
- String path = getURI().getPath();
-
- return path.indexOf(BundledSystemLibraryManager.BUNDLED_LIBRARY_PREFIX) != -1;
- }
-
}
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.deploy/META-INF/MANIFEST.MF ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698