Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 8602004: Fix code generation issue with new factory syntax. (Closed)

Created:
9 years, 1 month ago by regis
Modified:
9 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix code generation issue with new factory syntax. Convert VM core library to new factory syntax. Committed: https://code.google.com/p/dart/source/detail?r=1662

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M runtime/lib/array.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 6 chunks +21 lines, -8 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
Srdjan, This fixes the issue you encountered in your pending cl. Thanks, Regis
9 years, 1 month ago (2011-11-18 05:11:09 UTC) #1
srdjan
LGTM (I will discard my CL since this CL does it as well). http://codereview.chromium.org/8602004/diff/1/runtime/vm/parser.cc File ...
9 years, 1 month ago (2011-11-18 17:42:30 UTC) #2
regis
9 years, 1 month ago (2011-11-18 17:45:46 UTC) #3
Thanks

http://codereview.chromium.org/8602004/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8602004/diff/1/runtime/vm/parser.cc#newcode6067
runtime/vm/parser.cc:6067: bool Parser::IsInstantiatorRequired() {
On 2011/11/18 17:42:30, srdjan wrote:
> Can this method be const?

Yes. Done.

Powered by Google App Engine
This is Rietveld 408576698