Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2540)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 8602004: Fix code generation issue with new factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | runtime/vm/code_generator_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 1661)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -414,6 +414,7 @@
if (mismatch) {
const String& interface_name = String::Handle(interface.Name());
const String& factory_name = String::Handle(factory_class.Name());
+ // TODO(regis): Report the filename and position as well.
ReportError("mismatch in number or names of type parameters between "
"factory clause of interface '%s' and actual factory "
"class '%s'.\n",
@@ -727,6 +728,7 @@
type_class.NumTypeParameters(),
type_class.NumTypeParameters() > 1 ? "s" : "");
} else {
+ // TODO(regis): Report the filename and position as well.
ReportError("factory method '%s' must declare %d type parameter%s.\n",
function_name.ToCString(),
type_class.NumTypeParameters(),
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | runtime/vm/code_generator_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698