Issue 8598023: Print uninstantiated type with --trace_type_checks for instanceof (easier to identify what caused...

Issue 8598023: Print uninstantiated type with --trace_type_checks for instanceof (easier to identify what caused... (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Print uninstantiated type with --trace_type_checks for instanceof (easier to identify what caused calls to runtime). Committed: https://code.google.com/p/dart/source/detail?r=1676

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	runtime/vm/code_generator.cc	View	1 2	1 chunk	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one suggestion. http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc#newcode340 runtime/vm/code_generator.cc:340: OS::Print("InstanceOf: '%s' %s '%s (%s)'\n", ...

9 years, 1 month ago (2011-11-18 22:26:18 UTC) #2

srdjan

http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc#newcode340 runtime/vm/code_generator.cc:340: OS::Print("InstanceOf: '%s' %s '%s (%s)'\n", On 2011/11/18 22:26:18, regis ...

9 years, 1 month ago (2011-11-18 22:49:55 UTC) #3

regis

9 years, 1 month ago (2011-11-18 23:15:50 UTC) #4

On 2011/11/18 22:49:55, srdjan wrote:
> http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc
> File runtime/vm/code_generator.cc (right):
> 
>
http://codereview.chromium.org/8598023/diff/3001/runtime/vm/code_generator.cc...
> runtime/vm/code_generator.cc:340: OS::Print("InstanceOf: '%s' %s '%s (%s)'\n",
> On 2011/11/18 22:26:18, regis wrote:
> > Using parenthesis to display the uninstantiated type together with the
> > instantiated one may be confusing in the presence of function types. How
about
> > adding a separate line showing the generic (non-instantiated) version of the
> > type?
> 
> Changed to output of fromm:
> 
> InstanceOf: 'Smi' is ! 'A<int>' instantiated from 'A<T>'

Thanks!

Expand Messages | Collapse Messages