Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: runtime/vm/code_generator.cc

Issue 8598023: Print uninstantiated type with --trace_type_checks for instanceof (easier to identify what caused... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 1674)
+++ runtime/vm/code_generator.cc (working copy)
@@ -328,15 +328,21 @@
Bool::True() : Bool::False());
if (FLAG_trace_type_checks) {
const Type& instance_type = Type::Handle(instance.GetType());
- Type& instantiated_type = Type::Handle(type.raw());
- if (!type.IsInstantiated()) {
+ if (type.IsInstantiated()) {
+ OS::Print("InstanceOf: '%s' %s '%s'\n",
+ String::Handle(instance_type.Name()).ToCString(),
+ (result.raw() == Bool::True()) ? "is" : "is !",
+ String::Handle(type.Name()).ToCString());
+ } else {
// Instantiate type before printing.
- instantiated_type = type.InstantiateFrom(type_instantiator, 0);
+ const Type& instantiated_type =
+ Type::Handle(type.InstantiateFrom(type_instantiator, 0));
+ OS::Print("InstanceOf: '%s' %s '%s' instantiated from '%s'\n",
+ String::Handle(instance_type.Name()).ToCString(),
+ (result.raw() == Bool::True()) ? "is" : "is !",
+ String::Handle(instantiated_type.Name()).ToCString(),
+ String::Handle(type.Name()).ToCString());
}
- OS::Print("InstanceOf: '%s' %s '%s'\n",
- String::Handle(instance_type.Name()).ToCString(),
- (result.raw() == Bool::True()) ? "is" : "is !",
- String::Handle(instantiated_type.Name()).ToCString());
}
arguments.SetReturn(result);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698