Issue 8598011: Implement delete on File objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8598011: Implement delete on File objects. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement delete on File objects. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1652

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -5 lines)			Patch
M	runtime/bin/builtin_in.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/file.dart	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	6 chunks	+47 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/standalone/src/FileTest.dart	View	6 chunks	+19 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8598011/diff/1/tests/standalone/src/FileTest.dart File tests/standalone/src/FileTest.dart (right): http://codereview.chromium.org/8598011/diff/1/tests/standalone/src/FileTest.dart#newcode55 tests/standalone/src/FileTest.dart:55: file = new File(outFilenameBase + "_out"); Why wasn't ...

9 years, 1 month ago (2011-11-18 12:26:04 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-18 12:27:24 UTC) #3

http://codereview.chromium.org/8598011/diff/1/tests/standalone/src/FileTest.dart
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/8598011/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:55: file = new File(outFilenameBase +
"_out");
On 2011/11/18 12:26:04, Bill Hesse wrote:
> Why wasn't this test failing before?  Has that problem been fixed?

Because the test copies input file to output file. Then check that output file
contains the same as input file. What happened here was that in a previous
change I messed up the test so it tested that input file still contains the
same. :-)

Expand Messages | Collapse Messages