Implement delete on File objects.

tests/standalone/src/FileTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing file I/O.
 
 
 class FileTest {
   // Test for file read functionality.
   static int testReadStream() {
@@ skipping 26 matching lines @@
   static int testReadWriteStream() {
     // Read a file.
     String inFilename = getFilename("tests/vm/data/fixed_length_file");
     File file = new File(inFilename);
     FileInputStream input = file.openInputStream();
     List<int> buffer1 = new List<int>(42);
     int bytesRead = input.readInto(buffer1, 0, 42);
     Expect.equals(42, bytesRead);
     input.close();
     // Write the contents of the file just read into another file.
-    String outFilename = getFilename("tests/vm/data/fixed_length_file");
-    file = new File(outFilename + "_out");
+    String outFilenameBase = getFilename("tests/vm/data/fixed_length_file");
+    file = new File(outFilenameBase + "_out");
     OutputStream output = file.openOutputStream();
     bool writeDone = output.writeFrom(buffer1, 0, 42);
     Expect.equals(true, writeDone);
     output.close();
     // Now read the contents of the file just written.
     List<int> buffer2 = new List<int>(42);
-    file = new File(outFilename);
+    file = new File(outFilenameBase + "_out");

[Bill Hesse, 2011/11/18 12:26:04]

Why wasn't this test failing before?  Has that problem been fixed?

[Mads Ager (google), 2011/11/18 12:27:24]

Because the test copies input file to output file. Then check that output file
contains the same as input file. What happened here was that in a previous
change I messed up the test so it tested that input file still contains the
same. :-)

     input = file.openInputStream();
     bytesRead = input.readInto(buffer2, 0, 42);
     input.close();
     Expect.equals(42, bytesRead);
     // Now compare the two buffers to check if they are identical.
     for (int i = 0; i < buffer1.length; i++) {
       Expect.equals(buffer1[i],  buffer2[i]);
     }
+    // Delete the output file.
+    file.deleteSync();
+    Expect.isFalse(file.existsSync());
     return 1;
   }
 
   static int testRead() {
     // Read a file and check part of it's contents.
     String filename = getFilename("bin/file_test.cc");
     File file = new File(filename);
     file.errorHandler = (s) {
       Expect.fail("No errors expected");
     };
@@ skipping 73 matching lines @@
             file.fullPathHandler = (s) {
               Expect.isTrue(new File(s).existsSync());
               if (s[0] != '/' && s[0] != '\\' && s[1] != ':') {
                 Expect.fail("Not a full path");
               }
               file.openHandler = () {
                 file.noPendingWriteHandler = () {
                   file.closeHandler = () {
                     // Now read the contents of the file just written.
                     List<int> buffer2 = new List<int>(bytes_read);
-                    file = new File(getFilename(outFilenameBase));
+                    file = new File(getFilename(outFilenameBase + "_out"));
                     file.errorHandler = (s) {
                       Expect.fail("No errors expected");
                     };
                     file.openHandler = () {
                       file.readListHandler = (bytes_read) {
                         Expect.equals(42, bytes_read);
                         file.closeHandler = () {
                           // Now compare the two buffers to check if they
                           // are identical.
                           Expect.equals(buffer1.length, buffer2.length);
                           for (int i = 0; i < buffer1.length; i++) {
                             Expect.equals(buffer1[i],  buffer2[i]);
                           }
+                          // Delete the output file.
+                          file.deleteHandler = () {
+                            file.existsHandler = (exists) {
+                              Expect.isFalse(exists);
+                            };
+                            file.exists();
+                          };
+                          file.delete();
                         };
                         file.close();
                       };
                       file.readList(buffer2, 0, 42);
                     };
                     file.open();
                   };
                   file.close();
                 };
                 file.writeList(buffer1, 0, bytes_read);
@@ skipping 31 matching lines @@
     String path = file.fullPathSync();
     if (path[0] != '/' && path[0] != '\\' && path[1] != ':') {
       Expect.fail("Not a full path");
     }
     Expect.isTrue(new File(path).existsSync());
     file.openSync(true);
     file.writeListSync(buffer1, 0, bytes_read);
     file.closeSync();
     // Now read the contents of the file just written.
     List<int> buffer2 = new List<int>(bytes_read);
-    file = new File(getFilename(outFilenameBase));
+    file = new File(getFilename(outFilenameBase + "_out"));
     file.openSync();
     bytes_read = file.readListSync(buffer2, 0, 42);
     Expect.equals(42, bytes_read);
     file.closeSync();
     // Now compare the two buffers to check if they are identical.
     Expect.equals(buffer1.length, buffer2.length);
     for (int i = 0; i < buffer1.length; i++) {
       Expect.equals(buffer1[i],  buffer2[i]);
     }
+    // Delete the output file.
+    file.deleteSync();
+    Expect.isFalse(file.existsSync());
     return 1;
   }
 
   // Test for file length functionality.
   static int testLength() {
     String filename = getFilename("tests/vm/data/fixed_length_file");
     File input = new File(filename);
     input.errorHandler = (s) {
       Expect.fail("No errors expected");
     };
@@ skipping 330 matching lines @@
     Expect.equals(1, testCloseException());
     Expect.equals(1, testCloseExceptionStream());
     Expect.equals(1, testBufferOutOfBoundsException());
     Expect.equals(1, testMixedSyncAndAsync());
   }
 }
 
 main() {
   FileTest.testMain();
 }