Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 8592008: Factor out code part for instanceof, and hardwire "is bool" check. (Closed)

Created:
9 years, 1 month ago by srdjan
Modified:
9 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Factor out code part for instanceof, and hardwire "is bool" check. Committed: https://code.google.com/p/dart/source/detail?r=1770

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M runtime/vm/code_generator_ia32.cc View 1 2 3 4 2 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
9 years, 1 month ago (2011-11-21 21:33:22 UTC) #1
regis
LGTM However, I do not find the factorized code easier to read. On the contrary, ...
9 years, 1 month ago (2011-11-21 22:02:35 UTC) #2
srdjan
Could you please have another look (+13 ,-15 lines, while adding a test). On 2011/11/21 ...
9 years, 1 month ago (2011-11-22 00:25:29 UTC) #3
regis
LGTM Nice!
9 years, 1 month ago (2011-11-22 00:37:43 UTC) #4
srdjan
9 years, 1 month ago (2011-11-22 01:36:54 UTC) #5
On 2011/11/22 00:37:43, regis wrote:
> LGTM
> 
> Nice!

Thanks for complaining about the original change :-).

Powered by Google App Engine
This is Rietveld 408576698