Factor out code part for instanceof, and hardwire "is bool" check.

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1445 matching lines @@
                                 type_class,
                                 TypeArguments::Handle())) {
         __ PushObject(negate_result ? bool_false : bool_true);
       } else {
         __ PushObject(negate_result ? bool_true : bool_false);
       }
       __ jmp(&done, Assembler::kNearJump);
 
       // Compare if the classes are equal.
       __ Bind(&compare_classes);
-      if (type_class.is_interface()) {
-        if (type.IsStringInterface()) {
-          Label runtime_call;
-          __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
-          const Class& one_byte_string_class = Class::ZoneHandle(
-              Isolate::Current()->object_store()->one_byte_string_class());
-          __ CompareObject(ECX, one_byte_string_class);
-          __ j(NOT_EQUAL, &runtime_call, Assembler::kNearJump);
-          __ PushObject(negate_result ? bool_false : bool_true);
-          __ jmp(&done, Assembler::kNearJump);
-          __ Bind(&runtime_call);
-        }
-      } else {  // type_class is not an interface.
+      const Class* compare_class = NULL;
+      if (type.IsStringInterface()) {
+        compare_class = &Class::ZoneHandle(
+            Isolate::Current()->object_store()->one_byte_string_class());
+      } else if (type.IsBoolInterface()) {
+        compare_class = &Class::ZoneHandle(
+            Isolate::Current()->object_store()->bool_class());
+      } else if (!type_class.is_interface()) {
+        compare_class = &type_class;
+      }
+      if (compare_class != NULL) {
         Label runtime_call;
         __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
-        __ CompareObject(ECX, type_class);
+        __ CompareObject(ECX, *compare_class);
         __ j(NOT_EQUAL, &runtime_call, Assembler::kNearJump);
         __ PushObject(negate_result ? bool_false : bool_true);
         __ jmp(&done, Assembler::kNearJump);
         __ Bind(&runtime_call);
       }
     }
   }
   const Object& result = Object::ZoneHandle();
   __ PushObject(result);  // Make room for the result of the runtime call.
   __ pushl(EAX);  // Push the instance.
@@ skipping 17 matching lines @@
     __ Bind(&negate_done);
     __ pushl(EAX);
   }
   __ Bind(&done);
 }
 
 
 // Jumps to label if ECX equals the given class.
 // Inputs:
 // - ECX: tested class.
-void CodeGenerator::TestClassAndJump(const Class& cls, Label *label) {
+void CodeGenerator::TestClassAndJump(const Class& cls, Label* label) {
   __ CompareObject(ECX, cls);
   __ j(EQUAL, label, Assembler::kNearJump);
 }
 
 
 static const Class* CoreClass(const char* c_name) {
   const String& class_name = String::Handle(String::NewSymbol(c_name));
   const Class& cls = Class::ZoneHandle(Library::Handle(
       Library::CoreImplLibrary()).LookupClass(class_name));
   ASSERT(!cls.IsNull());
@@ skipping 1231 matching lines @@
                         message_buffer, kMessageBufferSize,
                         format, args);
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, message_buffer);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32