Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 8591031: Fix some type warnings in html library (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly
Modified:
9 years, 1 month ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some type warnings in html library. Two changes: * factories for Element are typed to return Element. That way we know they're downcastable to things like CanvasElement. * switch "final" to an explicit "dom.HTMLElement", so we know it has innerHTML on it. (from looking at the static tpes, it thought "temp" was just an dom.Element. You're probably familiar with this "feature" of the DOM... ;-) ) Committed: https://code.google.com/p/dart/source/detail?r=1637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M client/html/release/html.dart View 15 chunks +18 lines, -18 lines 0 comments Download
M client/html/src/ElementWrappingImplementation.dart View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
Sorry about the whitespace noise in the diff--my TextMate is set up to automatically kill ...
9 years, 1 month ago (2011-11-17 22:17:02 UTC) #1
Jacob
9 years, 1 month ago (2011-11-17 22:20:28 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698