Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: client/html/release/html.dart

Issue 8591031: Fix some type warnings in html library (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/html/src/ElementWrappingImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/release/html.dart
diff --git a/client/html/release/html.dart b/client/html/release/html.dart
index ebb9e28f0230a942da6348c9ba06ddaa67eda817..34d065439d1d866ce95f0d752b683ed8adc04f7e 100644
--- a/client/html/release/html.dart
+++ b/client/html/release/html.dart
@@ -16932,7 +16932,7 @@ interface AbstractWorker extends EventTarget {
class AbstractWorkerEventsImplementation extends EventsImplementation implements AbstractWorkerEvents {
AbstractWorkerEventsImplementation._wrap(_ptr) : super._wrap(_ptr);
-
+
EventListenerList get error() => _get('error');
}
@@ -16940,7 +16940,7 @@ class AbstractWorkerWrappingImplementation extends EventTargetWrappingImplementa
AbstractWorkerWrappingImplementation._wrap(ptr) : super._wrap(ptr);
AbstractWorkerEvents get on() {
- if (_on === null) {
+ if (_on === null) {
_on = new AbstractWorkerEventsImplementation._wrap(_ptr);
}
return _on;
@@ -17035,7 +17035,7 @@ interface BodyElementEvents extends ElementEvents {
EventListenerList get unLoad();
}
-interface BodyElement extends Element {
+interface BodyElement extends Element {
BodyElementEvents get on();
}
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
@@ -22294,7 +22294,7 @@ interface Document extends Element /*, common.NodeSelector */ {
// BSD-style license that can be found in the LICENSE file.
interface DocumentFragment extends Element factory DocumentFragmentWrappingImplementation {
-
+
DocumentFragment();
DocumentFragment.html(String html);
@@ -22807,7 +22807,7 @@ interface DOMApplicationCacheEvents extends Events {
EventListenerList get noUpdate();
EventListenerList get obsolete();
EventListenerList get progress();
- EventListenerList get updateReady();
+ EventListenerList get updateReady();
}
interface DOMApplicationCache extends EventTarget {
@@ -22867,7 +22867,7 @@ class DOMApplicationCacheWrappingImplementation extends EventTargetWrappingImple
if (_on === null) {
_on = new DOMApplicationCacheEventsImplementation._wrap(_ptr);
}
- return _on;
+ return _on;
}
}
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
@@ -23539,15 +23539,15 @@ class ElementRectWrappingImplementation implements ElementRect {
// TODO(jacobr): should we move these outside of ElementRect to avoid the
// overhead of computing them every time even though they are rarely used.
// This should be type dom.ClientRect but that fails on dartium. b/5522629
- final _boundingClientRect;
+ final _boundingClientRect;
// an exception due to a dartium bug.
final dom.ClientRectList _clientRects;
ElementRectWrappingImplementation(dom.HTMLElement element) :
client = new SimpleClientRect(element.clientLeft,
element.clientTop,
- element.clientWidth,
- element.clientHeight),
+ element.clientWidth,
+ element.clientHeight),
offset = new SimpleClientRect(element.offsetLeft,
element.offsetTop,
element.offsetWidth,
@@ -23572,7 +23572,7 @@ class ElementRectWrappingImplementation implements ElementRect {
}
class ElementWrappingImplementation extends NodeWrappingImplementation implements Element {
-
+
static final _START_TAG_REGEXP = const RegExp('<(\\w+)');
static final _CUSTOM_PARENT_TAG_MAP = const {
'body' : 'html',
@@ -23589,7 +23589,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
'track' : 'audio',
};
- factory ElementWrappingImplementation.html(String html) {
+ factory Element.html(String html) {
// TODO(jacobr): this method can be made more robust and performant.
// 1) Cache the dummy parent elements required to use innerHTML rather than
// creating them every call.
@@ -23605,11 +23605,11 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
parentTag = _CUSTOM_PARENT_TAG_MAP[tag];
}
}
- final temp = dom.document.createElement(parentTag);
+ dom.HTMLElement temp = dom.document.createElement(parentTag);
temp.innerHTML = html;
if (temp.childElementCount == 1) {
- return LevelDom.wrapElement(temp.firstElementChild);
+ return LevelDom.wrapElement(temp.firstElementChild);
} else if (parentTag == 'html' && temp.childElementCount == 2) {
// Work around for edge case in WebKit and possibly other browsers where
// both body and head elements are created even though the inner html
@@ -23620,7 +23620,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
}
}
- factory ElementWrappingImplementation.tag(String tag) {
+ factory Element.tag(String tag) {
return LevelDom.wrapElement(dom.document.createElement(tag));
}
@@ -23802,7 +23802,7 @@ class ElementWrappingImplementation extends NodeWrappingImplementation implement
}
void set scrollLeft(int value) { _ptr.scrollLeft = value; }
-
+
void set scrollTop(int value) { _ptr.scrollTop = value; }
Future<ElementRect> get rect() {
@@ -24048,7 +24048,7 @@ class EventsImplementation implements Events {
EventListenerList operator [](String type) {
return _get(type.toLowerCase());
}
-
+
EventListenerList _get(String type) {
return _listenerMap.putIfAbsent(type,
() => new EventListenerListImplementation(_ptr, type));
@@ -25731,7 +25731,7 @@ class StorageEventWrappingImplementation extends EventWrappingImplementation imp
// BSD-style license that can be found in the LICENSE file.
interface Text extends CharacterData factory TextWrappingImplementation {
-
+
Text(String content);
String get wholeText();
@@ -27322,7 +27322,7 @@ class WindowWrappingImplementation extends EventTargetWrappingImplementation imp
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-interface WorkerEvents extends AbstractWorkerEvents {
+interface WorkerEvents extends AbstractWorkerEvents {
EventListenerList get message();
}
« no previous file with comments | « no previous file | client/html/src/ElementWrappingImplementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698